Edited ReadMe.md #4
Closed
+45
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to target this PR at the Azure/azure-sdk-for-net repo. |
Which branch should I target? Should I wait until this PR is merged? |
|
We normally target the "main" branch, which is automatic when creating a PR against the main Azure/azure-sdk-for-net repo. We don't normally target feature or release branches. |
heaths
pushed a commit
that referenced
this pull request
Jan 2, 2024
* Update autorest.md file with latest swagger and allow model duplication * Generate and upgrade sdk code * Customize redis common configuration code to include aad-enabled * Regenerate API file * Customize redis common configuration code to include aad-enabled * Mitigate breaking change * Create empty test-resources.json * Create FlushFunctionalTests.cs * Update assets.json * Add functional tests for aad (#2) Adds functional tests for aad * Update Channel Tests (#3) * Oscarba/fix (#4) * Update Channel Tests * Update correct data type * Push regenerated code * UpdateChannelFix (#5) * Update Channel Tests * Update correct data type * Update test * Update tag for assets after push for recordings * Address reviewer comments * Update generatred code after mergin in main * Update FTs for updated models * Update AAD FT * Update assets.json * Update changelog --------- Co-authored-by: Kanchan Joshi <kanchanjoshi@microsoft.com> Co-authored-by: Austin Tolani <austintolani@microsoft.com> Co-authored-by: Oscar Barbosa Aquino <32723476+Darfeikus@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted Readme. However the references to service documentation should be adjusted in a later PR; this is because CLU docs are currently in private preview and not yet available to the public.
Also one thing to note: In the general troubleshooting section, line 97, it is stated that this invalid request should return a 400 (bad request error). However, when I tested it myself (using my own resource), I got a 401 unauthorized access error, although both the key and the endpoint
TestEnvironmentvariables were correctly set. Could this be a service issue? Can someone please try to run that test using their resources and let me know if they get the correct 400 exception?